-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support sepolia #136
Conversation
@TTNguyenDev is attempting to deploy a commit to the Nation3 DAO Team on Vercel. A member of the Team first needs to authorize it. |
packages/web-app/lib/connectors.tsx
Outdated
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_GOERLI; | ||
break; | ||
case 11155111: | ||
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that I have to add this variable in the Vercel config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the old code, but it would be better if we only needed NEXT_PUBLIC_ALCHEMY_API_KEY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so also. Having one variable name per chain is just weird. Let's refactor those later, in a separate pull request: #139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already update it in my latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added NEXT_PUBLIC_CHAIN
= sepolia
in the Vercel config for the Sepolia project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, wait a second, something is weird here. We don't need NEXT_PUBLIC_CHAIN since our app supports multiple chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, testing and debugging gets easier if we use one subdomain (and one Vercel project) per chain. That's how we are doing it with the other Nation3 dApps, so probably makes most sense to treat the Agreements dApp the same way?
app.nation3.org, app-sepolia.nation3.org
income.nation3.org, income-sepolia.nation3.org
agreements.nation3.org, agreements-sepolia.nation3.org
export const arbitratorAddress = "0xBe67cEdCD1FE38aac8a5781A51250FDeFB344E6C"; | ||
export const cohortAddress = "0xfbb66bc799308435ed2a0e0c0ac3ad1d46749b7b"; | ||
export const safeTxServiceUrl = "https://safe-transaction-sepolia.safe.global"; | ||
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to deploy something for the Graph API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not sure. I need to take a look at this and test the app to see if there are any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aahna-ashina Can you share the current subgraphURI that https://agreements.nation3.org/ is using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aahna-ashina Can you share the current subgraphURI that https://agreements.nation3.org/ is using
Do you mean the NEXT_PUBLIC_GRAPH_API_URL
environment variable?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dework Task
https://app.dework.xyz/nation3/open-bounties-95838?taskId=8c5123e9-bb2b-4efe-a3fe-7d832e91186e
#135