Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support sepolia #136

Closed
wants to merge 12 commits into from
Closed

Conversation

TTNguyenDev
Copy link
Contributor

@TTNguyenDev TTNguyenDev commented Feb 28, 2024

Copy link

vercel bot commented Feb 28, 2024

@TTNguyenDev is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

@TTNguyenDev
Copy link
Contributor Author

#135

@TTNguyenDev
Copy link
Contributor Author

image

apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_GOERLI;
break;
case 11155111:
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that I have to add this variable in the Vercel config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the old code, but it would be better if we only needed NEXT_PUBLIC_ALCHEMY_API_KEY.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so also. Having one variable name per chain is just weird. Let's refactor those later, in a separate pull request: #139

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already update it in my latest commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added NEXT_PUBLIC_CHAIN = sepolia in the Vercel config for the Sepolia project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, wait a second, something is weird here. We don't need NEXT_PUBLIC_CHAIN since our app supports multiple chains.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, testing and debugging gets easier if we use one subdomain (and one Vercel project) per chain. That's how we are doing it with the other Nation3 dApps, so probably makes most sense to treat the Agreements dApp the same way?

app.nation3.org, app-sepolia.nation3.org
income.nation3.org, income-sepolia.nation3.org
agreements.nation3.org, agreements-sepolia.nation3.org

export const arbitratorAddress = "0xBe67cEdCD1FE38aac8a5781A51250FDeFB344E6C";
export const cohortAddress = "0xfbb66bc799308435ed2a0e0c0ac3ad1d46749b7b";
export const safeTxServiceUrl = "https://safe-transaction-sepolia.safe.global";
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to deploy something for the Graph API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'm not sure. I need to take a look at this and test the app to see if there are any problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either, but this is what Nation3's Subgraph dashboard looks like:

Copy link
Contributor Author

@TTNguyenDev TTNguyenDev Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aahna-ashina Can you share the current subgraphURI that https://agreements.nation3.org/ is using

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aahna-ashina Can you share the current subgraphURI that https://agreements.nation3.org/ is using

Do you mean the NEXT_PUBLIC_GRAPH_API_URL environment variable?

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agreements-app-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 5:48am

@aahna-ashina
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants